Skip to content

Try very high staticPageGenerationTimeout value #5128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Try very high staticPageGenerationTimeout value #5128

wants to merge 1 commit into from

Conversation

@MananTank
Copy link
Member

@MananTank MananTank commented Oct 22, 2024 •
edited by pr-codex bot
Loading

Problem solved

Short description of the bug fixed or feature added

PR-Codex overview

This PR focuses on improving the configuration for static page generation in a Next.js application and addressing issues related to dynamic page rendering.

Detailed summary

  • In next.config.js, added staticPageGenerationTimeout set to 500.
  • Removed comments and the dynamic export set to "force-dynamic" in apps/dashboard/src/app/(dashboard)/explore/page.tsx.
  • Removed comments and the dynamic export set to "force-dynamic" in apps/dashboard/src/app/(dashboard)/explore/[category]/page.tsx.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@vercel
Copy link

vercel bot commented Oct 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ❌ Failed (Inspect) Oct 22, 2024 7:47pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Oct 22, 2024 7:47pm
thirdweb_playground ⬜️ Skipped (Inspect) Oct 22, 2024 7:47pm
wallet-ui ⬜️ Skipped (Inspect) Oct 22, 2024 7:47pm

@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:21 Inactive
@MananTank MananTank mentioned this pull request Oct 22, 2024
Merged
@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 07d9c5f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:21 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:21 Inactive
@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 22, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@MananTank Graphite App
Copy link
Member Author

MananTank commented Oct 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @MananTank and the rest of your teammates on Graphite Graphite

@MananTank MananTank mentioned this pull request Oct 22, 2024
Merged
@github-actions github-actions bot added the Dashboard Involves changes to the Dashboard. label Oct 22, 2024
@MananTank MananTank marked this pull request as ready for review October 22, 2024 18:23
@codecov
Copy link

codecov bot commented Oct 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.28%. Comparing base (9c3ff94) to head (07d9c5f).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5128   +/-   ##
=======================================
  Coverage   45.28%   45.28%           
=======================================
  Files        1060     1060           
  Lines       54831    54831           
  Branches     3955     3955           
=======================================
  Hits        24832    24832           
  Misses      29308    29308           
  Partials      691      691
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 9c3ff94
packages 40.23% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 42.81 KB (0%) 857 ms (0%) 3 s (-29.24% 🔽) 3.9 s
thirdweb (cjs) 102.66 KB (0%) 2.1 s (0%) 7.4 s (+23.04% 🔺) 9.4 s
thirdweb (minimal + tree-shaking) 4.84 KB (0%) 97 ms (0%) 244 ms (-20.25% 🔽) 341 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 95 ms (-31.58% 🔽) 105 ms
thirdweb/react (minimal + tree-shaking) 17.36 KB (0%) 348 ms (0%) 374 ms (-56.73% 🔽) 721 ms

@MananTank MananTank changed the base branch from 10-22-move__explore_page_to_rscs to graphite-base/5128 October 22, 2024 18:44
@MananTank MananTank force-pushed the 10-22-try_very_high_staticpagegenerationtimeout_value branch from 36b2f7d to 3244d26 Compare October 22, 2024 18:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:49 Inactive
@MananTank MananTank changed the base branch from graphite-base/5128 to main October 22, 2024 18:49
@MananTank MananTank force-pushed the 10-22-try_very_high_staticpagegenerationtimeout_value branch from 3244d26 to 07d9c5f Compare October 22, 2024 18:49
@vercel vercel bot temporarily deployed to Preview – wallet-ui October 22, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – docs-v2 October 22, 2024 18:49 Inactive
@vercel vercel bot temporarily deployed to Preview – thirdweb_playground October 22, 2024 18:49 Inactive
@MananTank MananTank closed this Oct 22, 2024
@vercel vercel bot temporarily deployed to Preview – thirdweb-www October 22, 2024 19:15 Inactive
@MananTank MananTank deleted the 10-22-try_very_high_staticpagegenerationtimeout_value branch December 18, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnsdls jnsdls Awaiting requested review from jnsdls

@joaquim-verges joaquim-verges Awaiting requested review from joaquim-verges

Assignees

No one assigned

Labels

Dashboard Involves changes to the Dashboard.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@MananTank